Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 response for DELETE stops test suite #160

Open
Jonahss opened this issue Aug 22, 2014 · 2 comments
Open

500 response for DELETE stops test suite #160

Jonahss opened this issue Aug 22, 2014 · 2 comments

Comments

@Jonahss
Copy link
Collaborator

Jonahss commented Aug 22, 2014

Every now and then a test fails, and the retry logic attempts to DELETE the failing test.
And every so often, the DELETE command itself throws a 500 error.

In this case, grunt-saucelabs should just continue, and not halt.

@gvas
Copy link
Contributor

gvas commented Aug 26, 2014

If grunt-saucelabs simply ignores the failed DELETE command then the failed saucelabs job will be probably preserved. This in turn will cause the saucelabs badge/status image to report the build as failed, in spite of the retry logic may have completed the test successfully.
So I think grunt-saucelabs should repeat the DELETE command until it succeeds.
It will be tricky to write tests for this.

@Jonahss
Copy link
Collaborator Author

Jonahss commented Aug 26, 2014

It might be the case that no matter how many retries are made, if the
DELETE fails the job might not exist. I'm thinking that having your test
suite complete is more important than the badge, since your build will
still pass.

How about three retries, then continue with a warning in the log output.
On Aug 25, 2014 10:56 PM, "Vas Gábor" [email protected] wrote:

If grunt-saucelabs simply ignores the failed DELETE command then the
failed saucelabs job will be probably preserved. This in turn will cause
the saucelabs badge/status image to report the build as failed, in spite of
the retry logic may have completed the test successfully.
So I think grunt-saucelabs should repeat the DELETE command until it
succeeds.
It will be tricky to write tests for this.


Reply to this email directly or view it on GitHub
#160 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants