New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase URL length limit #441

Closed

skrimix wants to merge 1 commit into axel-download-accelerator:master from skrimix:increase-url-limit

skrimix commented Jul 1, 2024

Current limit is too aggressive and truncates e.g. CloudFront signed URLs.

As per RFC 9110:

It is RECOMMENDED that all senders and recipients support, at a minimum, URIs with lengths of 8000 octets in protocol elements. Note that this implies some structures and on-wire representations (for example, the request line in HTTP/1.1) will necessarily be larger in some cases.

Fixes #440, closes #407


          conn: Increase URL length limit to 8000

ff86a62

Member

ismaell commented Jul 3, 2024 •

edited

Loading

Please use a proper email address.
Don't touch MAX_STRING.
Avoid allocating large stuff in the stack, it's bad enough as it is now (that's why touching MAX_STRING isn't a good idea).

ismaell closed this

ismaell added the Rejected label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels