Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata propagation #39

Open
nabuskey opened this issue Oct 3, 2024 · 1 comment
Open

Metadata propagation #39

nabuskey opened this issue Oct 3, 2024 · 1 comment

Comments

@nabuskey
Copy link

nabuskey commented Oct 3, 2024

Currently, Symphony does not propagate metadata like custom labels and annotations on a claim to resources. It also does not detect changes to metadata because it looks for generation changes.
https://github.com/aws-controllers-k8s/private-symphony/blob/34d870209ee0f575afbae7a9d704583c79e72f78/internal/dynamiccontroller/dynamic_controller.go#L382-L387

This is problematic for a few reasons:

  1. For use cases where user specified labels and annotations are needed. For example, needing to allocate costs by labels and annotations needed by custom controllers.
  2. Using gitops tools like argocd where it relies on labels and annotations to track resources associated with an application. e.g. users cannot see resources associated with claims in the UI.
  3. Object backup becomes difficult. e.g. you can't really use Velero to backup specific resources associated with an app.
@nabuskey
Copy link
Author

nabuskey commented Oct 4, 2024

Ok tested more with main. It does work for ArgoCD visualization since ownerReferences are set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants