Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x-kubernetes-int-or-string: true from schema #168

Open
wscoble opened this issue Dec 10, 2024 · 0 comments
Open

Support x-kubernetes-int-or-string: true from schema #168

wscoble opened this issue Dec 10, 2024 · 0 comments

Comments

@wscoble
Copy link

wscoble commented Dec 10, 2024

Feature Description

Problem Statement:

I would like to use flagger (and other) controllers that have fields configured with x-kubernetes-int-or-string: true meaning that the field can be an integer or a string. KRO doesn't seem to work with this right now.

The dummy CR generation doesn't know how to handle this configuration yet and fails.

Proposed Solution:

The dummy CR generator should use an integer for CR generation.

Alternatives Considered:

I've patched the flagger schema to force int or string and it works, but since their schema is valid and widely used, kro should probably handle their case.

Additional Context:

  • Please vote on this issue by adding a 👍 reaction to the original issue
  • If you are interested in working on this feature, please leave a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant