Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow creation of ResourceGroups if value of immutable field is invalid #165

Open
amirahav opened this issue Dec 9, 2024 · 0 comments
Labels
kind/bug Something isn't working

Comments

@amirahav
Copy link

amirahav commented Dec 9, 2024

Description

Observed Behavior:
kro currently allows a ResourceGroup with an invalid value of an immutable field to be created.
This then requires the deletion and recreation of the ResourceGroup.

Expected Behavior:
The kro controller returns an error and doesn't create the ResourceGroup.

Reproduction Steps (Please include ResourceGroup and Instances files):

apiVersion: kro.run/v1alpha1
kind: ResourceGroup
metadata:
  name: sqs-queue
spec:
  schema:
    apiVersion: v1alpha1
    kind: sqs-queue
    spec:
      ...

Versions:

  • kro version:
  • Kubernetes Version (kubectl version):

Involved Controllers:

  • Controller URLs and Versions (if applicable):
  • kro v0.1.0

Error Logs (if applicable)**:

Paste any relevant logs here
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Which option describes the most your issue?

No response

@amirahav amirahav added the kind/bug Something isn't working label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant