Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the bikeshed #33

Open
graebm opened this issue Jul 18, 2024 · 1 comment
Open

Name the bikeshed #33

graebm opened this issue Jul 18, 2024 · 1 comment

Comments

@graebm
Copy link
Contributor

graebm commented Jul 18, 2024

Global issue for naming nitpicks, to be addressed before GA. Put your grievances here so we can move on with PRs...
@graebm
Copy link
Contributor Author

graebm commented Jul 18, 2024

Don't name anything "request" or "response" unless you're literally talking about 1 HTTP request/response.

A "download" is not a "request", because it may correspond to N HTTP requests under the hood. I learned this lesson from many muddled discussions about "meta requests" in aws-c-s3.

@aajtodd aajtodd mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graebm