From c4b032dd7fe801646a6265f56cbe7144f21fd501 Mon Sep 17 00:00:00 2001 From: Dmitriy Musatkin <63878209+DmitriyMusatkin@users.noreply.github.com> Date: Wed, 13 Nov 2024 09:32:39 -0800 Subject: [PATCH] disable visibility hidden on old gcc (#1167) --- cmake/AwsCFlags.cmake | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmake/AwsCFlags.cmake b/cmake/AwsCFlags.cmake index 18ebb712c..93c4c8163 100644 --- a/cmake/AwsCFlags.cmake +++ b/cmake/AwsCFlags.cmake @@ -257,6 +257,10 @@ function(aws_set_common_properties target) # We do this so that backtraces are more likely to show function names. # We mostly use backtraces to diagnose memory leaks. if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug") - set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON) + # And dont hide symbols on anything pre GCC 5.0 (Visibility support was not great on older compilers and some libraries didnt annotate visibility - + # looking at you jni, which does not annotate on gcc less than 4.2. Mixing no annotation and hidden symbols leads to unexpected failures.). + if (NOT (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0")) + set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON) + endif () endif () endfunction()