Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EKS-A build account to Prow cred helpers config #635

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

abhay-krishna
Copy link
Member

We need this to be able to use the build account ECR cache in EKS-A presubmits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign srbgupta86 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jaxesn jaxesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@abhay-krishna
Copy link
Member Author

Force merging this since Tide won't automerge due to the GitHub action returning a Skipped conclusion.

@abhay-krishna abhay-krishna merged commit 96f8928 into aws:main Oct 3, 2024
1 of 2 checks passed
@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Updated the following 2 configmaps:

  • build-setup configmap in namespace default at cluster prow-presubmits-cluster using the following files:
    • key docker-ecr-config.json using file config/docker-ecr-config.json
  • build-setup configmap in namespace default at cluster prow-postsubmits-cluster using the following files:
    • key docker-ecr-config.json using file config/docker-ecr-config.json

In response to this:

We need this to be able to use the build account ECR cache in EKS-A presubmits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants