Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update images-upstream-bins to use default env vars to fix image push #1493

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

vineeth-bandi
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added golang go Pull requests that update Go code projects Updates or changes to the projects being built labels Aug 7, 2024
@vineeth-bandi
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vineeth-bandi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rcrozean
Copy link
Member

rcrozean commented Aug 7, 2024

/lgtm

@vineeth-bandi vineeth-bandi merged commit b76b145 into aws:main Aug 7, 2024
4 of 5 checks passed
@vineeth-bandi vineeth-bandi deleted the update-golang-postsubmits branch August 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved go Pull requests that update Go code golang lgtm projects Updates or changes to the projects being built size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants