Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Golang Release go tool #1112

Merged
merged 40 commits into from
Oct 24, 2023
Merged

Conversation

rcrozean
Copy link
Member

@rcrozean rcrozean commented Aug 14, 2023

Issue #, if available:

Description of changes:
These changes create a release object for eks go releases. The plan is to have a func (r Release) NewRelease, func (r Release) UpdateMinorVersion, and potentially func (r Release) Backport command.

NewRelease would be for new minor version releases.
Example PR: rcrozean#64
PR was created with this tool using command: eksGoRelease new --eksGoReleases=1.21.0 -v 4

Update would be to update supported upstream versions when patch versions are released
Example PR: rcrozean#67
PR was created with this tool using command: eksGoRelease update --eksGoReleases=1.20.5 -v 4
For the example PR an arbitrary patch version was selected.

Backport would be to attempt to patch eksGo versions not supported by upstream

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcrozean rcrozean changed the title WIP: Create Golang Release go tool Create Golang Release go tool Aug 18, 2023
Copy link
Member

@danbudris danbudris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the direction this is going in, left some thoughts.

I'd be nice to have the temp values in the dummy files be meaningful comments or pointers to documentation. This could come in a follow-on PR but wanted to capture it here.

We do need to make sure we paramaterize the git user -- wether that's through a flag, and env var, or derived from the git config. It might be easiest to use an env var for this as it would easily support both the CLI use-case as well as the Prow plugin use case

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 3, 2023
@rcrozean rcrozean force-pushed the projectFactory branch 2 times, most recently from 4f92991 to 92e0f61 Compare October 12, 2023 17:45
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Oct 12, 2023

@rcrozean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
golang-1-21-tooling-presubmit 4b59c57 link true /test golang-1-21-tooling-presubmit
eks-distro-base-tooling-presubmits-golang-1-21-al-2023 4b59c57 link true /test eks-distro-base-tooling-presubmits-golang-1-21-al-2023
eks-distro-base-tooling-presubmits-golang-1-21-al-2 4b59c57 link true /test eks-distro-base-tooling-presubmits-golang-1-21-al-2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions github-actions bot added golang go Pull requests that update Go code projects Updates or changes to the projects being built labels Oct 24, 2023
@rcrozean
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rcrozean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xdu31
Copy link
Member

xdu31 commented Oct 24, 2023

/lgtm

@eks-distro-bot eks-distro-bot merged commit 34324ca into aws:main Oct 24, 2023
3 checks passed
@rcrozean rcrozean deleted the projectFactory branch October 25, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation go Pull requests that update Go code golang lgtm projects Updates or changes to the projects being built size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants