-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Golang Release go tool #1112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the direction this is going in, left some thoughts.
I'd be nice to have the temp
values in the dummy files be meaningful comments or pointers to documentation. This could come in a follow-on PR but wanted to capture it here.
We do need to make sure we paramaterize the git user -- wether that's through a flag, and env var, or derived from the git config. It might be easiest to use an env var for this as it would easily support both the CLI use-case as well as the Prow plugin use case
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
tools/eksDistroBuildToolingOpsTools/pkg/eksGoRelease/eksGoRelease.go
Outdated
Show resolved
Hide resolved
c2c8aeb
to
248d806
Compare
4f92991
to
92e0f61
Compare
@rcrozean: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
92e0f61
to
f9b7fe8
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rcrozean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Issue #, if available:
Description of changes:
These changes create a release object for eks go releases. The plan is to have a
func (r Release) NewRelease
,func (r Release) UpdateMinorVersion
, and potentiallyfunc (r Release) Backport
command.NewRelease
would be for new minor version releases.Example PR: rcrozean#64
PR was created with this tool using command:
eksGoRelease new --eksGoReleases=1.21.0 -v 4
Update
would be to update supported upstream versions when patch versions are releasedExample PR: rcrozean#67
PR was created with this tool using command:
eksGoRelease update --eksGoReleases=1.20.5 -v 4
For the example PR an arbitrary patch version was selected.
Backport
would be to attempt to patch eksGo versions not supported by upstreamBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.