[WIP] Convert to vanilla JavaScript modules (ES Modules) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e them manually when we need to
* fix-broken-webpack-dependency: pin webpack dependency versions so they won't break, and we can update them manually when we need to
…having Webpack provide it, and instead import it as a regular JavaScript module (note that Three.js has deprecated the global and will provide only JavaScript modules at version 0.160)
|
very interested in this. maybe double check "removed hard-coded Cognito IDs". good work. |
…bit different than other libs, and we should allow people to try newer versions, while if something breaks we can claim that it at least works with 0.127.0
…ettier, use eslint only for non-formatting rules
… AWS from 'aws-sdk'`, fix three.texttospeech.html test
This was referenced Oct 5, 2023
Open
…o need for `exports` unless multiple paths need configuring, or CommonJS support is needed, but we're no longer explicitly supporting CommonJS modules, and CommonJS users can use the `import()` function to import the lib, and they can even use the `deasync` package if they really really want the import to be "synchronous", so there's really no need to hold onto the past and we can make moving forward as simple and standards-based as possible)
…st CDN link to aws-sdk and use the local version, and update docs as needed for the new ESM format without a required build
|
At this point, ESM changes are complete, and this is representative of the new repo format in every way. We just need to apply the fix for Babylon's animation API. |
@theVoiceMouse Thanks! Indeed, I'll squash this, and I'll void that key and make myself a new one. :) |
This was referenced Oct 13, 2023
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is branched off of the branch for
See that PR first. For convenience, here's the diff between the branches, as the
Files changedwill not be as useful.Description
Converts examples to JavaScript (ES) modules, and imports all libraries via
importsyntax (except forAWSwhich is still a global var from a non-module script).This is WIP, all examples and integration tests load, but Babylon demos have a break from Babylon 5 (see below). We also need to
webpack.config.jsbecause we're not building the source anymore (unless we still need them for Karma unit tests)start-*scripts so they open a particular example's folder (similar to what webpack dev server was doing)importthem, but it breaks the character animations, which we will need to fix:Related Issue #
Reviewer Testing Instructions
npm installnpx live-server .at the root of the repo to start a static web server,Submission Checklist
I confirm that I have...
This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.