-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basicauth extension to collectors #1930
Comments
Would also love to see this land 🙌 Interestingly came across this issue while trying to set up Tempo and following Grafana's docs. |
Plus one from here as well, also we'd like to see oauth2client extension to allow more sophisticated 3rd parties |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This issue was closed because it has been marked as stale for 30 days with no activity. |
Bump? |
Updates on it? I really want this extension! |
Thanks for reaching out @johnjunjiezhao and could you share your use case please? |
Hi @mhausenblas , I want the adot sidecar on my ecs cluster also sends traces to grafana cloud. According their guide, I need this extension. https://grafana.com/docs/opentelemetry/collector/send-otlp-to-grafana-cloud-databases/ I think it will be convenient if adot can have it. Thanks! |
@johnjunjiezhao if you can use Grafana's OTLP gateway (currently only available in some regions) it's possible to send data to Grafana Cloud with a config similar to this: exporters:
otlphttp:
endpoint: "https://otlp-gateway-prod-eu-west-2.grafana.net/otlp"
headers: {"Authorization": "Basic the-base64-encoded-value"}
service:
pipelines:
traces:
receivers: [otlp]
processors: [batch/traces]
exporters: [otlphttp]
metrics:
receivers: [otlp]
processors: [batch/metrics]
exporters: [otlphttp]
logs:
receivers: [otlp]
processors: [batch/logs]
exporters: [otlphttp] where I suspect it's possible to set the basic auth header manually like this also for https://grafana.com/docs/opentelemetry/collector/send-otlp-to-grafana-cloud-databases/, but I haven't tried it, as I'm able to use Grafana's OTLP gateway. Still, +1 for requesting the extension, it would make using basic auth easier and clearer. |
Thanks @wjoel , I am using it. And I do think this extension is useful to make auth cleaner |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Keep open |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Keep open |
I want to configure auth using this extension b/w Auto instrumentation resource and an Otel collector. Can someone please help me out? |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Not stale |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Not stale |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Not stale. @mhausenblas any Feedback for us here? |
Is your feature request related to a problem? Please describe.
As a user, I want to use credentials in a transparent way, without having to transform them first. As such,
basic
auth credentials currently have to be base64 encoded and passed as raw header array.Describe the solution you'd like
The otelcol-contrib offers a
basicauth
extension so configuration and secret values become more readable and less opaque.The following example uses the extension and allows users to work with explicit values instead of opaque strings:
I thought this was a straight forward change so I added the implementation in #1923 which is ready to bring in. The extension itself is very lean and doesnt add a lot of overhead in the binary or the startup.
The text was updated successfully, but these errors were encountered: