Remove EFS CSI Driver as it is an EKS add-on now

[askulkarni2]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

Now that EFS CSI driver is an EKS add-on we should remove it from blueprints. https://docs.aws.amazon.com/eks/latest/userguide/eks-add-ons.html#workloads-add-ons-available-eks

Describe the solution you would like

Remove it from main.tf.

Describe alternatives you have considered

Additional context

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

Issue closed due to inactivity.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

Issue closed due to inactivity.

[ahoehma]

@askulkarni2 do you have more details about the "how to use" the addon with eks module directly?

[bryantbiggs]

The implementation is the same between the EKS module and this module; any EKS addon listed here can be enabled by specifying the addon configuration under cluster_addons in the EKS module, or eks_addons for this module, with the name as the key to addons respective configuration map. To enable the addon with the default values/settings, just simply specify an empty map as the value:

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 20.0"

  # Truncated for brevity ...

  cluster_addons = {
    coredns = {
      most_recent = true
    }
    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      most_recent = true
    }
    aws-efs-csi-driver = {}
  }
}

module "eks_blueprints_addons" {
  source  = "aws-ia/eks-blueprints-addons/aws"
  version = "~> 1.0"

  # Truncated for brevity ...

  eks_addons = {
    coredns = {
      most_recent = true
    }
    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      most_recent = true
    }
    aws-efs-csi-driver = {}
  }
}

[ahoehma]

@bryantbiggs aha ... nice to know ... I struggled little bit with the 2 locations :-) What is the "best practice"?

[bryantbiggs]

The EKS module has the ability to let users specify before_compute = true to ensure the addon is provisioned before any dataplane compute resources which is helpful for configuring the VPC CNI daemonset. Otherwise, the implementations are identical so its really up to how users and how they wish to manage their addons