Closing comments handling #9

const-volatile · 2017-08-01T06:46:35Z

I found a corner case, in which closing comments are not handled correctly. i.e.

The end of the comment is marked by the second <!-->, but accidentally everything afterwards will be treated as comment also.

The following snippet demonstrates the problem (output is empty instead of "HELLO WORLD"):

html::dom page;
page.append_partial_html("<!--x>Comment<!--><html><head><title>HELLO WORLD</title></head><body></body></html>");
std::cout << page["title"].to_plain_text() << std::endl;

According to the HTML5 specification, parsing of the comment should happen as following:

Data state
< Markup declaration open state
-- Comment start state
x comment state
>Comment<! Append the current input character to the comment token's data
- Comment end dash state
- Comment end state
> Data state

Current implementation is in comment state (state = 12) while >Comment is getting parsed, but switches the state when the <! characters are encountered to state = 10.

case '<':
  {
    c = getc();
    if (c == '!') {
      pre_state = state;
      state = 10;
    } else {
      content += '<';
      content += c;
    }
  }
  break;

The text was updated successfully, but these errors were encountered:

avplayer#9 Treating '<' and '<!' in state=12 (comment state) like any other token ("Append the current input character to the comment token's data.", See also: https://www.w3.org/TR/html5/syntax.html#comment-state).

const-volatile mentioned this issue Aug 1, 2017

#9: Closing comments handling #10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closing comments handling #9

Closing comments handling #9

const-volatile commented Aug 1, 2017 •

edited

Loading

Closing comments handling #9

Closing comments handling #9

Comments

const-volatile commented Aug 1, 2017 • edited Loading

const-volatile commented Aug 1, 2017 •

edited

Loading