Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add Scrolling Lyrics Display in the Menu Bar #48

Open
fx-k opened this issue Sep 20, 2024 · 3 comments
Open

Suggestion: Add Scrolling Lyrics Display in the Menu Bar #48

fx-k opened this issue Sep 20, 2024 · 3 comments

Comments

@fx-k
Copy link

fx-k commented Sep 20, 2024

I have noticed that when the lyrics are too long, they don’t display in the menu bar, with some parts disappearing entirely.

I would like to suggest adding a scrolling lyrics feature to the menu bar, ensuring that regardless of the length of the lyrics, they can scroll automatically and be fully visible. This would greatly enhance the visual experience and overall usability.

Thank you for your hard work, and I hope this feature will be considered!

@aviwad
Copy link
Owner

aviwad commented Sep 21, 2024

Thank you for the feedback :) unfortunately being written in SwiftUI and using Apple's extremely restrictive MenuBarExtra component makes it very hard to display anything animating. This would require a rewrite requiring considerable effort. Perhaps I will get to it once my other to-dos are checked off. If anyone works on it and submits a PR I will accept it for sure!

@fx-k
Copy link
Author

fx-k commented Sep 21, 2024

Thank you for your attention to this issue!
I was wondering if it would be possible to implement a workaround by pre-processing the lyrics and splitting them into shorter segments that fit within the character limit. Would this be a more feasible approach to display the lyrics without needing extensive changes to the code? : )

@aviwad
Copy link
Owner

aviwad commented Sep 21, 2024

Hmm that's actually quite doable. I already have the difference between the current lyric and the next at hand (so say I know the current lyric line is to be displayed for 5 seconds, and is 20 characters), I could definitely split it into two strings and display them for half the time each. This would be very complicated, however, because I wouldn't want to tamper with the saved lyrics and only change the lyric array I have in memory. But at the same time since the user is free to change the menubar size during run time, I would have to account for that too. I'll keep this issue open because this is definitely a lot more doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants