Updated crux-xodus to xtdb-xodus #6
Conversation
There was a problem hiding this comment.
Thank you so much for this PR as you probably figured we are not using this extensively anymore. I only have a few small remarks and then I think we can merge it. I would also be happy to do a rename but I would like to discuss this with the XTDB team first so I don't break any links.
.vscode/settings.json
Outdated
| { | ||
| "java.configuration.updateBuildConfiguration": "interactive" | ||
| } |
There was a problem hiding this comment.
Please remove this and put in the gitignore
There was a problem hiding this comment.
Thanks for responding. I'm happy to maintain this adapter if your team is not using it anymore. I am curious as to why you are not and what you switched to as obviously I'm planning on using it for a project. I thought it was appropriate to change the name but I'm happy to change it back if it proves problematic. I've made the changes you've requested see the latest commit.
.gitignore
Outdated
| .lsp/.cache | ||
| .calva/output-window/output.calva-repl |
There was a problem hiding this comment.
This should be defined in your own .gitignore
There was a problem hiding this comment.
Done see latest commit and earlier response.
|
Just checking in. Have you had a chance to talk to the xtdb team? |
|
Hi :)
I just spotted this! We've not had a conversation but I see no harm in renaming, links should redirect automatically. |
I've updated the crux xodus to use adapter to use the latest version of xtdb (the rename of crux) and the latest version of xodus. I suggest renaming it to xtdb-xodus to match xtdb and have done the work necessary to do so. Let me know what you think.