Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request requirement too prescriptive #4975

Closed
1 task done
BooleanCat opened this issue Aug 14, 2023 · 2 comments
Closed
1 task done

Pull request requirement too prescriptive #4975

BooleanCat opened this issue Aug 14, 2023 · 2 comments

Comments

@BooleanCat
Copy link
Contributor

Search first

  • I searched and no similar issues were found

What Happened?

Heya folks. One of the requirements in the pull request template is:

The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

This seems to be a bit too prescriptive and precludes trunk-based-development workflows. I'd like to suggest making the requirement talk more about what I think the intention of this check is, perhaps something like:

Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

@phanirithvij
Copy link
Collaborator

Please send a PR changing this, thanks for catching this unnecessary restriction.

@BooleanCat
Copy link
Contributor Author

@phanirithvij Done: #4976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants