Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.name label to all metrics #27

Open
4 of 9 tasks
emschwartz opened this issue Jun 15, 2023 · 1 comment
Open
4 of 9 tasks

Add service.name label to all metrics #27

emschwartz opened this issue Jun 15, 2023 · 1 comment

Comments

@emschwartz
Copy link
Contributor

emschwartz commented Jun 15, 2023

As discussed here, we want to add a service service.name label to all the metrics we produce (all function. metrics and build_info).

It should be possible to load this label from an environment variable, or if there is an Autometrics initialization function it can be a parameter to that function. If a service name is not specified, the package name should be used by default.

All of the generated queries should be updated as well so that function metrics are identified by (function, module, service) (function, module, service_name).

@P2P-Nathan
Copy link

I'm for service labels and would like to drop a suggestion that when they hit the metrics they get added with the oTel service spec

@emschwartz emschwartz changed the title Add service label to all metrics Add service.name label to all metrics Jun 15, 2023
@emschwartz emschwartz moved this from Todo to In Progress in Autometrics Roadmap Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants