Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Illuminate\Support\Traits\Macroable trait to Guards #456

Open
1 task done
jose123v opened this issue May 9, 2024 · 1 comment · May be fixed by #459
Open
1 task done

feat: add Illuminate\Support\Traits\Macroable trait to Guards #456

jose123v opened this issue May 9, 2024 · 1 comment · May be fixed by #459
Labels
Scope: Improvement Proposed improvements, or feature additions.

Comments

@jose123v
Copy link

jose123v commented May 9, 2024 •
edited
Loading

Checklist

Description

Illuminate/Auth/RequestGuard.php#L8C5-L12
Illuminate/Auth/SessionGuard.php#L30-L32
Guards/TokenGuard.php#L28-L30

Laravel uses Macroable class on the guards, why not here too?

Shouldn't it maintain consistency?
@evansims evansims added the Scope: Improvement Proposed improvements, or feature additions. label Jun 4, 2024
@evansims
Copy link
Member

evansims commented Jun 4, 2024

Thanks for your feature suggestion, @jose123v! I think that makes sense, and I see no issue with adding support for that. If there are any volunteers, this would be a great first issue for someone to take!

@evansims evansims changed the title Add Illuminate\Support\Traits\Macroable to guards feat: add Illuminate\Support\Traits\Macroable trait to Guards Jun 4, 2024
@erikn69 erikn69 linked a pull request Jul 18, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Scope: Improvement Proposed improvements, or feature additions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add macroable guards erikn69/laravel-auth0
2 participants
@evansims @jose123v