Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work at all with darkmode #1

Open
103sbavert opened this issue Dec 3, 2020 · 0 comments
Open

Doesn't work at all with darkmode #1

103sbavert opened this issue Dec 3, 2020 · 0 comments

Comments

@103sbavert
Copy link

I feel like you need to improve the way you theme your app. You should define two themes with almost identical settings except in places where one uses light colors for icons and text the other uses dark colors. Put the one that uses light colors in values/night/app_theme.xml and the one that uses dark colors in values/app_theme.xml. That way depending on the user's night mode settings, the colors would change automatically. I could do it myself too but the architecture of the app is kind of too much for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant