Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: suffix-exact-match doesn't trim command first #2198

Open
1 task done
kidonng opened this issue Jun 25, 2024 · 0 comments
Open
1 task done

[Bug]: suffix-exact-match doesn't trim command first #2198

kidonng opened this issue Jun 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kidonng
Copy link

kidonng commented Jun 25, 2024

What did you expect to happen?

Searching command with suffix-exact-match ($) doesn't trim commands first, making some commands with trailing spaces unsearchable.

What happened?

Here's a little command in atuin:

Screenshot 2024-06-26 at 1 08 17 AM

You expect file$ to match it right? Wrong!

Screenshot 2024-06-26 at 1 08 23 AM

Let's Tab to see what it really is:

Screenshot 2024-06-26 at 1 08 35 AM

Turns out there's a space after the command (why the space is there is beyond me, atuin probably should have trimmed it when it saves the command). Comparing to another "normal" command makes the difference more clear:

Screenshot 2024-06-26 at 1 08 42 AM

Atuin doctor output

Atuin Doctor
Checking for diagnostics


Please include the output below with any bug reports or issues

{
  "atuin": {
    "version": "18.3.0",
    "sync": null,
    "sqlite_version": "3.44.0"
  },
  "shell": {
    "name": "fish",
    "default": "fish",
    "plugins": [
      "atuin"
    ],
    "preexec": "built-in"
  },
  "system": {
    "os": "Darwin",
    "arch": "arm64",
    "version": "14.5",
    "disks": [
      {
        "name": "Macintosh HD",
        "filesystem": "apfs"
      },
      {
        "name": "Macintosh HD",
        "filesystem": "apfs"
      }
    ]
  }
}

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kidonng kidonng added the bug Something isn't working label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant