Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestions for the tutorial on flow matching #88

Open
kilianFatras opened this issue Dec 15, 2023 · 10 comments
Open

Improvement suggestions for the tutorial on flow matching #88

kilianFatras opened this issue Dec 15, 2023 · 10 comments

Comments

@kilianFatras
Copy link
Collaborator

kilianFatras commented Dec 15, 2023

This issue is opened for users to suggest improvements for the Flow Matching tutorial notebook.

@radiradev
Copy link

radiradev commented Dec 22, 2023

Is it possible to include a minimal example of how a trained model can be used to evaluate the density of a given sample?

@atong01
Copy link
Owner

atong01 commented Dec 22, 2023

@radiradev Thats a great idea. I can work on this. If you have an immediate need or are interested in making one I can send over a dirty notebook for this.

@radiradev
Copy link

@atong01 That would be very much appreciated!

@kilianFatras
Copy link
Collaborator Author

We should give credit to stochastic interpolants and rectified flows at the beginning of the notebook. Basically saying that all 3 methods are similar and concurrent ICLR2023 papers

@hinzflorian
Copy link

hinzflorian commented Feb 13, 2024

Hi,
there is a typo in
Flow_matching_tutorial.ipynb:
"optximizer.zero_grad()" ->"optimizer.zero_grad()"

@kilianFatras
Copy link
Collaborator Author

Hi,
Thank you! I will correct that shortly.

@radiradev
Copy link

Is it possible to include a minimal example of how a trained model can be used to evaluate the density of a given sample?

Hi @atong01, could you please share your example notebook on how this is done? I saw here that to evaluate the density an ode must be solved, but I am not sure how to accomplish this in pytorch:

jax-fmx

@harveymannering
Copy link

Hello,

I cannot run the last cell in the Flow_matching_tutorial.ipynb notebook because the sample_xt function is not define. Does sample_xt serve the same purpose as sample_conditional_pt? Are the two functions interchangable?

Thank you for the tutorials!

@kilianFatras
Copy link
Collaborator Author

kilianFatras commented Mar 8, 2024

Oh that’s indeed a typo… I changed the name of the function last minute and forgot to change this. You are right! The correct function is sample_conditional_pt.

Edit: I have pushed a corrected tutorial.

@csufangyu
Copy link

We should give credit to stochastic interpolants and rectified flows at the beginning of the notebook. Basically saying that all 3 methods are similar and concurrent ICLR2023 papers

Your suggestion is fantastic, I'm a beginner and it looks like there is no difference between stochastic interpolants and rectified flows, except that stochastic interpolants have an extra random term and rectified flows seem to be a deterministic sampling, is my understanding Is my understanding correct? I look forward to your reply, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants