Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generate samples script #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a generate samples script #84

wants to merge 2 commits into from

Conversation

QB3
Copy link
Contributor

@QB3 QB3 commented Dec 11, 2023 •
edited
Loading

What does this PR do?

Add a script to generate multiple images for the CIFAR-10 examples

Fixes #73

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c0cfdd) 35.90% compared to head (6562e19) 35.90%.

❗ Current head 6562e19 differs from pull request most recent head c41f83d. Consider uploading reports for the commit c41f83d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   35.90%   35.90%           
=======================================
  Files          67       67           
  Lines        7419     7419           
=======================================
  Hits         2664     2664           
  Misses       4755     4755

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QB3
Copy link
Contributor Author

QB3 commented Dec 12, 2023

Since the generation might be time-consuming, we could also try to add a multi-GPU support.
I took a look at this script https://github.com/NVlabs/edm/blob/main/generate.py but it is unclear how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused num_images param in cifar10 example
1 participant
@QB3