Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure dotenv #19

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jun 7, 2024

Description:

This PR is to setu .env file to hide all secret keys and variables used in dynamite E-commerce project

Acceptance Criteria:

  • configure .env file containing environment variables is created.
  • Environment variables are added to the .env file.
  • Changes are committed with a meaningful commit message.
  • Changes are pushed to a new branch (configure-dotenv) on GitHub.

How to Run:

After pulling the changes, run

npm run dev

@13XAVI 13XAVI linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamites-ecomm-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 11:56am

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.24%. Comparing base (1d4ea43) to head (8883b95).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #19   +/-   ##
========================================
  Coverage    17.24%   17.24%           
========================================
  Files            4        4           
  Lines           29       29           
  Branches         4        4           
========================================
  Hits             5        5           
  Misses          21       21           
  Partials         3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@13XAVI 13XAVI added Front-End Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager labels Jun 7, 2024
@13XAVI 13XAVI self-assigned this Jun 7, 2024
@13XAVI 13XAVI requested a review from dushimeemma June 7, 2024 08:38
Copy link
Collaborator

@dushimeemma dushimeemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where .env.example file? @13XAVI

fix lint issue

resolved some file Path

added .env.example
@13XAVI 13XAVI force-pushed the ch-configure-environmental-variables-#5 branch from 106a0c7 to 094b745 Compare June 7, 2024 11:52
@dushimeemma dushimeemma merged commit 3fd4bb9 into develop Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-End Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Environmental Variables
5 participants