Configure TypeScript Paths #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
72ed96a to
e26c6a0
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
e26c6a0 to
b85fd7f
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
b85fd7f to
1e38004
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
1e38004 to
1a90338
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
2e32be8 to
ee4756a
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
ee4756a to
83a77db
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
83a77db to
0a1feb5
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
0a1feb5 to
ce65e84
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11 +/- ##
========================================
Coverage 17.24% 17.24%
========================================
Files 4 4
Lines 29 29
Branches 4 4
========================================
Hits 5 5
Misses 21 21
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Dawaic6
requested review from
bertrandshema,
dushimeemma,
EddyShimwa,
13XAVI,
ambroisegithub,
jkarenzi and
niyibi250
Dawaic6
added
ready for review
2 tasks
dushimeemma
requested changes
Jun 7, 2024
package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| "tailwindcss": "^3.4.3", | |||
| "typescript": "^5.2.2", | |||
| "vite": "^5.2.0", | |||
| "vite-tsconfig-paths": "^4.3.2", | |||
There was a problem hiding this comment.
where did you use this package?
src/main.tsx
Outdated
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom/client'; | |||
| import App from './App.tsx'; | |||
| import App from 'src/App.tsx'; | |||
| import './index.css'; | |||
There was a problem hiding this comment.
why don't you use the absolute import here?
src/main.tsx
Outdated
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom/client'; | |||
| import App from './App.tsx'; | |||
| import App from 'src/App.tsx'; | |||
There was a problem hiding this comment.
I would suggest to import like import App from @/App.tsx
tsconfig.json
Outdated
|
|
||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@src/*": ["src/*"], |
There was a problem hiding this comment.
use "@/*": ["./src/*" ]
vite.config.ts
Outdated
| @@ -17,4 +18,14 @@ export default defineConfig({ | |||
| environment: 'jsdom', | |||
| setupFiles: ['./src/__test__/setupTests.ts'], | |||
| }, | |||
| resolve: { | |||
| alias: { | |||
| '@': path.resolve(__dirname, 'src'), | |||
There was a problem hiding this comment.
use like "@": path.resolve(__dirname, "./src"),
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
ce65e84 to
d006611
Compare
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
d006611 to
6348fb0
Compare
- update vite config - set up docker [Finishes #10]
Dawaic6
force-pushed
the
ch-Configure-TypeScript-Paths-#8
branch
from
6348fb0 to
4b9e2b4
Compare
dushimeemma
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets up a new React project path aliases for TypeScript in a React project using Vite, making imports cleaner and more manageable for efficient development.
Description of Task to be Completed?