Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat some GraphQL Java types as pseudo sealed types #636

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Nov 27, 2024

No description provided.

Copy link

github-actions bot commented Nov 27, 2024

Test Results

  134 files  +1  134 suites  +1   56s ⏱️ -1s
1 002 tests +4  937 ✅ +4  65 💤 ±0  0 ❌ ±0 
1 010 runs  +4  945 ✅ +4  65 💤 ±0  0 ❌ ±0 

Results for commit 016ba16. ± Comparison against base commit bc72914.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
graphql.nadel.ForbiddenGraphQLJavaUsageTest ‑ do not access slow GraphQL Java methods()
graphql.nadel.NadelPrefixTest ‑ classes must be prefixed with Nadel()
graphql.nadel.NadelPrefixTest ‑ inner classes should not be prefixed with Nadel()
graphql.nadel.archunit.ForbiddenGraphQLJavaUsageTest ‑ do not access slow GraphQL Java methods()
graphql.nadel.archunit.NadelPrefixTest ‑ classes must be prefixed with Nadel()
graphql.nadel.archunit.NadelPrefixTest ‑ inner classes should not be prefixed with Nadel()
graphql.nadel.archunit.NadelPseudoSealedTypeKtTest ‑ whenType(GraphQLFieldsContainer)()
graphql.nadel.archunit.NadelPseudoSealedTypeKtTest ‑ whenType(GraphQLNamedType)()
graphql.nadel.archunit.NadelPseudoSealedTypeKtTest ‑ whenUnmodifiedType(GraphQLInputType)()
graphql.nadel.archunit.NadelPseudoSealedTypeKtTest ‑ whenUnmodifiedType(GraphQLOutputType)()

♻️ This comment has been updated with latest results.

@gnawf gnawf force-pushed the custom-hydration-directive-2 branch from b0cf2ca to a337f89 Compare December 2, 2024 00:04
@gnawf gnawf changed the base branch from custom-hydration-directive-2 to master December 2, 2024 03:36
@gnawf gnawf force-pushed the pseudo-sealed-types branch from b222238 to 016ba16 Compare December 2, 2024 03:37
Copy link
Collaborator

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the love of types

@gnawf gnawf merged commit 80d59ac into master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants