Add flat config preset for compiled & fix docs #1727
Conversation
AllySummers
requested review from
JakeLane,
pancaspe87,
liamqma and
dddlr
as code owners
🦋 Changeset detectedLatest commit: 4cdfe7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AllySummers
changed the title
| @@ -5,6 +5,8 @@ import { createNoTaggedTemplateExpressionRule, isKeyframes } from '../../utils'; | |||
| export const noKeyframesTaggedTemplateExpressionRule: Rule.RuleModule = { | |||
| meta: { | |||
| docs: { | |||
| recommended: true, | |||
There was a problem hiding this comment.
Adding a few recommended: true could be a problem, but this is a minor bump on a 0.x version which means major to me, LGTM if Eurybia is happy!
| get '@compiled'() { | ||
| return plugin; | ||
| }, |
There was a problem hiding this comment.
This is a bit more coherent than plugin.configs['flat/recommended'].plugins['@compiled'] = plugin which is what you'd have to do otherwise, right?
Only real concern is could this ever backfire with some Node support? I feel like it's been around forever but also a syntax I never use (because when it was introduced it wasn't ready to be used)…it's good now, right?
Also, would you ever want to merge this though?
| get '@compiled'() { | |
| return plugin; | |
| }, | |
| ...flatRecommended.plugins, | |
| get '@compiled'() { | |
| return plugin; | |
| }, |
AllySummers
dismissed stale reviews from liamqma and kylorhall-atlassian
via
24bf241
| | [@compiled/no-keyframes-tagged-template-expression](./src/rules/no-keyframes-tagged-template-expression) | Disallows the `keyframes` tagged template expression | :white_check_mark: | :wrench: | | ||
| | [@compiled/no-styled-tagged-template-expression](./src/rules/no-styled-tagged-template-expression) | Disallows the `styled` tagged template expression | :white_check_mark: | :wrench: | | ||
| | [@compiled/no-css-prop-without-css-function](./src/rules/no-css-prop-without-css-function) | Disallows css prop without the css function | :white_check_mark: | :wrench: | | ||
| ✅ Included in the recommended configuration.\ |
Co-authored-by: Grant Wong <[email protected]>
What is this change?
This PR:
Why are we making this change?
@compiled/eslint-plugincan use this with flat config without the legacy compat utilsPR checklist
Don't delete me!
I have...
website/Closes #1691