Skip to content

Commit

Permalink
Delete flow types (#1536)
Browse files Browse the repository at this point in the history
* Delete flow types

* Add changeset

* Remove flow from github workflows

* Fix prettier

* Remove flowconfig
  • Loading branch information
dddlr authored Oct 24, 2023
1 parent aff1856 commit f8d01fa
Show file tree
Hide file tree
Showing 38 changed files with 14 additions and 2,401 deletions.
6 changes: 6 additions & 0 deletions .changeset/purple-wolves-draw.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@compiled/react': minor
'@compiled/jest': minor
---

Remove Flow types as they are increasingly difficult to maintain
18 changes: 1 addition & 17 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
module.exports = {
root: true,
ignorePatterns: [
'dist',
'build',
'flow-typed',
'*.d.ts',
'babel-cjs.js',
'babel-esm.js',
'storybook-static',
],
ignorePatterns: ['dist', 'build', '*.d.ts', 'babel-cjs.js', 'babel-esm.js', 'storybook-static'],
overrides: [
{
files: ['*.{js,jsx,ts,tsx}'],
Expand Down Expand Up @@ -96,14 +88,6 @@ module.exports = {
],
},
},
{
files: ['*.js.flow'],
extends: ['plugin:flowtype/recommended'],
plugins: ['flowtype'],
rules: {
'flowtype/generic-spacing': 'off',
},
},
{
files: ['*.json'],
plugins: ['json-files'],
Expand Down
29 changes: 0 additions & 29 deletions .flowconfig

This file was deleted.

3 changes: 0 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,3 @@ jobs:

- name: Build webpack extracted example
run: yarn build:webpack:extract

- name: Compare committed flow types to generated
run: yarn flow-types compare
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ jobs:
- name: Build source for remainder tests
run: yarn build

- name: Run flow types validation
run: yarn flow-types validate

- name: Run import test
run: yarn test:imports

Expand Down
Loading

0 comments on commit f8d01fa

Please sign in to comment.