Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/mockup.py missing from the PyPi source tarball #1206

Closed
WOnder93 opened this issue Jul 25, 2023 · 8 comments · Fixed by #1215
Closed

tests/mockup.py missing from the PyPi source tarball #1206

WOnder93 opened this issue Jul 25, 2023 · 8 comments · Fixed by #1215

Comments

@WOnder93
Copy link
Contributor

The latest tarball doesn't contain the file, without which it is impossible to run the tests.
@gonchik
Copy link
Member

gonchik commented Jul 28, 2023

@WOnder93 it's strange, as I use the standard mechanism of Github to generating tarball.

I have uploaded a new release, please use it

@WOnder93
Copy link
Contributor Author

WOnder93 commented Aug 2, 2023

Thanks, but I didn't mean the GitHub tarballs (those are fine), but the source tarballs on PyPI (https://pypi.org/project/atlassian-python-api/#files). The 3.40.0 tarball there is till missing the file.

@gonchik
Copy link
Member

gonchik commented Aug 4, 2023

@WOnder93 noted

@gonchik
Copy link
Member

gonchik commented Aug 10, 2023

Hi!
on that commit extended package directory 8b90689

@gonchik gonchik closed this as completed Aug 13, 2023
@gonchik
Copy link
Member

gonchik commented Aug 13, 2023

@WOnder93 now it should be ok

@WOnder93
Copy link
Contributor Author

Thanks, but this solution doesn't seem correct. Now the package installs a toplevel tests package in addition to atlassian, which may conflict with some other package and likely isn't what users expect. Basically, when someone installs this version from PyPI, now they will end up with a tests directory under site-packages and if they do import tests anywhere, they will get the atlassian-python-api's tests package.

After I did some digging, I believe the right way to fix it is to undo the respective changes from 8b90689 and add recursive-include tests * to MANIFEST.in, so that the directory (and all its contents) is included in the source tarball, but not installed as a package.

@gonchik
Copy link
Member

gonchik commented Aug 15, 2023

@WOnder93 could you send a PR please?

@gonchik gonchik reopened this Aug 15, 2023
WOnder93 added a commit to WOnder93/atlassian-python-api that referenced this issue Aug 15, 2023
@WOnder93
Fix packaging of the tests directory
9350ea1 
Do not install tests as a package, but instead include it only in the
source tarball via MANIFEST.in.

I have verified that the resulting tarball installs only the 'atlassian'
package into site-packages and that the included files are sufficient to
successfully run the tests.

Fixes atlassian-api#1206

Signed-off-by: Ondrej Mosnáček <[email protected]>
@WOnder93 WOnder93 mentioned this issue Aug 15, 2023
Merged
@WOnder93
Copy link
Contributor Author

Sure, opened #1215

gonchik pushed a commit that referenced this issue Aug 16, 2023
@WOnder93
Fix packaging of the tests directory (#1215)
bad2d28 
Do not install tests as a package, but instead include it only in the
source tarball via MANIFEST.in.

I have verified that the resulting tarball installs only the 'atlassian'
package into site-packages and that the included files are sufficient to
successfully run the tests.

Fixes #1206

Signed-off-by: Ondrej Mosnáček <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix packaging of the tests directory WOnder93/atlassian-python-api
2 participants
@WOnder93 @gonchik