Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to subpackages breaks Meson build #127

Closed
russel opened this issue Aug 16, 2018 · 8 comments
Closed

Change to subpackages breaks Meson build #127

russel opened this issue Aug 16, 2018 · 8 comments

Comments

@russel
Copy link
Contributor

russel commented Aug 16, 2018

The rearrangement into subpackages has (obviously :-) broken the Meson build. I'll take responsibility for updating, no problem. However it may take a little while – I need to understand the new structure, how the Dub build works, and then translate that to the Meson build specification.

Will the new version be 0.8.0 rather than 0.7.50? (Meson versions are a real pain since they do not account for development builds, only release builds :-( so I need to update the number to the next release immediately.).

@atilaneves
Copy link
Owner

If I had my way, I'd change the version to 0.8.0, but due to this dub bug that apparently I'm the only who cares about, I can't.

@russel
Copy link
Contributor Author

russel commented Aug 16, 2018

I wonder if it is because people use >= rather than == for dependencies?

Matthias has given me an impetus to follow the way the Dub subpackage test builds work rather than the way the release builds work. Normally this would mean a meson.build file for each subpackage, as with Dub files, but I am conscious I am ending up polluting your project. I will try and do it all in the top-level meson.build.

@atilaneves
Copy link
Owner

I always use ~>. Regardless, any and all incompatibilities between their usage of unit-threaded for testing and a dependent library's, and you can't build. Even though the dependency's version of unit-threaded isn't ever going to be in the build.

Yesterday or the day before I wanted to create a build directory and move everything there but I wasn't sure if that would break the meson build.

@russel
Copy link
Contributor Author

russel commented Aug 16, 2018

Given there is a total restructuring of the project, now would be the time to make any and all changes you want. The Meson build is only there because I asked, it is therefore my problem to make it work!

@russel
Copy link
Contributor Author

russel commented Aug 17, 2018

Meson seems to work with the meson.build file in the build directory, even though all the documentation says it should be in the project directory. Still getting that linker error though on building get_ut_main. This is very strange, but investigation continues.

@russel
Copy link
Contributor Author

russel commented Nov 20, 2018

I rearranged the subpackages into alphabetic order to help check the content of the meson.build file, and spontaneously the build works.

@atilaneves
Copy link
Owner

Feel free to issue a PR to close this.

@russel
Copy link
Contributor Author

russel commented Nov 20, 2018

Pull request #134 submitted.

@russel russel closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants