Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the config file format #577

Open
KhudaDad414 opened this issue Nov 13, 2023 · 2 comments
Open

update the config file format #577

KhudaDad414 opened this issue Nov 13, 2023 · 2 comments
Labels
enhancement New feature or request stale

Comments

@KhudaDad414
Copy link
Member

KhudaDad414 commented Nov 13, 2023

Reason/Context

the current structure of the configuration file is not up to date I suggest we remove the following configurations :

export default async function () {
  return {
    ws: {
      server: {
        port: process.env.PORT, // user should use the asyncapi file.
      },
      client: { // they can use the auth function
        auth: {
          token: process.env.TOKEN
        }
      }
    }
    mqtt: { // user can use the auth function instead of the config file.
      auth: ({serverName, parsedAsyncAPI}) => {
        if (serverName === 'mqtt') {
          return {
            cert: async () => fs.readFileSync('./cert')
            clientId: '123',
            username: 'user1'
            password: 'pass12'
          }
        }
      }
    },
    http: {
      server: {
        port: process.env.PORT, // usage of asyncapi file for port should be encouraged.
      },
      client: { // user can use the auth function
        auth: {
          token: process.env.TOKEN
        },
        query: { // I don't know why it is here.
          foo: 'bar'
        },
        body: { // I don't know why it is here.
          foo: 'bar'
        }
      }
    }
  };
}

cc: @Souvikns

@KhudaDad414 KhudaDad414 added the enhancement New feature or request label Nov 13, 2023
@KhudaDad414 KhudaDad414 changed the title change the http config update the config file format Nov 21, 2023
@Souvikns
Copy link
Member

Taking this up

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants