-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glee crashes when body is not proper json in http request #476
Comments
Hi @KhudaDad414 I would like to take up this issue. |
@SrijanShovit go ahead mate. just let me know if you needed some help. 😄 |
Hey I tried setting up, but got confused how to run the project😅 |
@SrijanShovit to run the project:
I hope this helps, if it does not feel free to share which step you are stuck with. |
Hi @KhudaDad414 @Souvikns , I tried to run the project as per the steps told above,but got the following error: I tried understanding about the error, but as I am new , I couldn't. |
@SrijanShovit the error should be gone now. please delete you |
@KhudaDad414 @SrijanShovit Working fine for me after following those steps 👍 |
Is anyone working on this, should we put this issue for hacktoberfest? |
Hi. I can work on this if no one's assigned 😅 |
Hi @AnishKacham, you can start working on the issue. please let me know if you need some help. |
Followed this guide for it |
@Min2who the issue has been resolved. please try with the latest version. |
Still getting the same error. Seems like there is some conflict at Glee version tested: 0.36.14 |
@peter-rr messages:
- $ref: "#/channels/TRIGGER/messages/string" @utnim2 I don't see your asyncapi file but I think your issue is the same. |
@KhudaDad414 glee/examples/http-test/asyncapi.yaml Line 49 in ed66e84
|
@KhudaDad414 Working correctly now after changing the operation messages as you mentioned above. I've opened a PR to fix that issue: #805 |
@peter-rr merged. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
If the the request body does not contain proper json as glee expects, it will crush with the following error:
![Screenshot 2023-07-10 at 17 13 00](https://private-user-images.githubusercontent.com/32505158/252401352-1e0dc1b1-d624-4968-9670-1d3534c6c8dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2NzkxOTksIm5iZiI6MTcyNTY3ODg5OSwicGF0aCI6Ii8zMjUwNTE1OC8yNTI0MDEzNTItMWUwZGMxYjEtZDYyNC00OTY4LTk2NzAtMWQzNTM0YzZjOGRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDAzMTQ1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMzMGEyMTlhYzhjZDUzYzMyNzk3OGNmN2QwOWRkZmNmMDBhMTgzZjFlNDE5NWNiNzhiZGRhMDJkNGU4MTlmMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QPBe_KnAvt-VrHzxd-Y7V9FaCd2jQvihdFCHgazfH6U)
Expected behaviour
check if user's HTTP request is documented in AsyncAPI file, if it is not, then show proper message on server console and send a
404
error to the client.Glee should show a proper message instead of crushing if proper json is not passed to by the client.
The text was updated successfully, but these errors were encountered: