Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do you perform domain validation on IP addresses? #15

Open
d-e-s-o opened this issue Dec 28, 2019 · 3 comments
Open

Why do you perform domain validation on IP addresses? #15

d-e-s-o opened this issue Dec 28, 2019 · 3 comments

Comments

@d-e-s-o
Copy link

d-e-s-o commented Dec 28, 2019

See above. When I try to connect to an IP address I get a complaint about an invalid domain. Other TLS crates seem fine with an IP to connect to. Why is this check in place for IP addresses?
@Demi-Marie
Copy link
Contributor

This is a missing feature in WebPKI.

@sachanganesh
Copy link

Just to clarify, is there any work-around to the domain validation? I want to test against a local tls server, but I'm encountering the "invalid domain" error with little additional context.

If someone could provide a solution to the error, a work-around, or resources for further reading that would be greatly appreciated.

Thanks in advance!

@Demi-Marie
Copy link
Contributor

The only workarounds are:

  • Implement it oneself with a custom certificate verifier.
  • Implement it oneself and get it upstreamed to WebPKI.
  • Pay Brian Smith to add support for it to WebPKI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sachanganesh @d-e-s-o @Demi-Marie