Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async std::os::unix::fs::FileExt read_at/write_at #576

Open
Xorlev opened this issue Nov 22, 2019 · 2 comments · May be fixed by #947
Open

Async std::os::unix::fs::FileExt read_at/write_at #576

Xorlev opened this issue Nov 22, 2019 · 2 comments · May be fixed by #947

Comments

@Xorlev
Copy link

Xorlev commented Nov 22, 2019

Hi folks,

I was curious whether async-std would be interested in an async port of std::os::unix::fs::FileExt. I'm writing a service right now that'd benefit from such a thing -- currently I've been doing it myself by using std::os::unix::fs::FileExt::read_at with spawn_blocking, but it'd be neat to be included in async-std.

If there's interest in this, I could try my hand at a PR.

@ghost
Copy link

ghost commented Nov 22, 2019

Yes! :) We haven't quite finished the async_std::os module. A PR with FileExt would be very welcome!

@vlovich
Copy link

vlovich commented Jan 30, 2021

I want to try my hand here. Organizationally, does this get added to src/os/windows/fs.rs and src/os/unix/fs.rs?

vlovich added a commit to vlovich/async-std that referenced this issue Jan 30, 2021
Addresses issue async-rs#576 to add pwrite/pread support to async_std for
parity with std & tokio.
@vlovich vlovich linked a pull request Jan 30, 2021 that will close this issue
vlovich added a commit to vlovich/async-std that referenced this issue Feb 2, 2021
Addresses issue async-rs#576 to add pwrite/pread support to async_std for
parity with std & tokio.
vlovich added a commit to vlovich/async-std that referenced this issue Feb 2, 2021
Addresses issue async-rs#576 to add pwrite/pread support to async_std for
parity with std & tokio.
vlovich added a commit to vlovich/async-std that referenced this issue Feb 2, 2021
Addresses issue async-rs#576 to add pwrite/pread support to async_std for
parity with std & tokio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants