Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and tests for setup_helpers.pkg_config #5

Open
astrofrog opened this issue Jan 20, 2019 · 5 comments
Open

Add documentation and tests for setup_helpers.pkg_config #5

astrofrog opened this issue Jan 20, 2019 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@astrofrog
Copy link
Member

The setup_helpers.pkg_config function is used in several of astropy's setup_package.py files, so we should keep it here, but it isn't tested or documented, so that will need to be fixed.

@astrofrog astrofrog transferred this issue from astropy/astropy-helpers Dec 18, 2019
@astrofrog astrofrog added the help wanted Extra attention is needed label Dec 18, 2019
@saimn
Copy link
Contributor

saimn commented Dec 18, 2019

The function is simple enough, so I'm not sure if it is worth changing, but there is a python package wrapping pkg-config: https://github.com/matze/pkgconfig
I saw it used by some package I don't remember. It is a single file so it could be bundled, which would also remove the need to test and document our version.

@astrofrog
Copy link
Member Author

Oh interesting! Actually if we want to go down that road I suggest we just remove that from extension-helpers and have packages add pkgconfig to their pyproject.toml and use it directly. Is there any reason not to do that?

@saimn
Copy link
Contributor

saimn commented Dec 18, 2019

Oh yes indeed, that would be even simpler.

@Cadair
Copy link
Member

Cadair commented Dec 19, 2019

👍 for removing everything we can 😀

@astrofrog
Copy link
Member Author

I won't have time to investigate this in the near future, but if one of you has time to take a look, feel free to open a PR to astropy core to demonstrate how we could use the pkgconfig package instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants