Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in ImageFileCollection.filter #814

Open
RuiningZHAO opened this issue Dec 13, 2023 · 1 comment
Open

A bug in ImageFileCollection.filter #814

RuiningZHAO opened this issue Dec 13, 2023 · 1 comment
Labels

Comments

@RuiningZHAO
Copy link

There is a bug in ImageFileCollection.filter.

class ImageFileCollection:
    ...
    def filter(self, **kwd):
        ...
        files = self.files_filtered(include_path=True, **kwd)
        return ImageFileCollection(filenames=files,
                                   keywords=self.keywords)

The call of ImageFileCollection here should be with arg ext, otherwise the keywords not in the first extension will become -- in the returned collection.

@mwcraig mwcraig added the bug label Dec 18, 2023
@mwcraig
Copy link
Member

mwcraig commented Dec 18, 2023

Thanks for reporting this, @RuiningZHAO -- I'll try to get to this in the next couple of weeks, but I'd be happy to review a PR to fix it sooner than that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants