Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined image's uncertainty can use the wrong class #742

Open
saimn opened this issue Jul 29, 2020 · 0 comments
Open

Combined image's uncertainty can use the wrong class #742

saimn opened this issue Jul 29, 2020 · 0 comments

Comments

@saimn
Copy link

saimn commented Jul 29, 2020

If I give CCDData objects with a VarianceUncertainty to the combiner, I get a VarianceUncertainty in the output object, but I guess this should be a StdDevUncertainty since this is what is computed (or the stddev values should be converted to the ouput object's uncertainty type).
Problem is that the values are copied directly to the output's uncertainty, though this one is copied from the input list and can be a different type.

ccdproc/ccdproc/combiner.py

Lines 428 to 430 in 89db354

combined_image = CCDData(np.asarray(data.data, dtype=self.dtype),
mask=mask, unit=self.unit,
uncertainty=StdDevUncertainty(uncertainty))

ccd.uncertainty.array[x:xend, y:yend] = comb_tile.uncertainty.array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant