-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider revising the Combiner machinery into a class heirarchy #578
Comments
@eteq it is an interesting thought. We do have the I do notice that it is not included in the combining images documentation, and should be added to the top of that. Nonetheless, the |
Gotcha @crawfordsm - yeah, re-optimizing is definitely a good time/excuse to do this. And I didn't know about the To be clear, though, I would argue the But am I right in I'm guessing the idea is that the |
I was trying to use
Combiner
recently, and I found it a bit awkward to use because a single combiner class has all the methods. So I want to through out an idea for a new way to lay out the combiner:CombinerBase
or something like that which implements most of the bookeeping - pretty much everything except the*_combine
methods. Include acombine_images
abstract method.MedianCombiner
,SumCombiner
, andAverageCombiner
classes that basically just implementcombine_images
, using parameters from the init function, not method keywords.Combiner
, but it basically is just a compatibility class that wraps the above (might be deprecated in the future, but could also be left in with just a pointer that the class heirarchy is the "new" way).My reasoning behind all of this is that it makes it much easier to use these classes in a pipeline, because in this scheme, you can create a
*Combiner
and then just callcombine_images
, and a downstream user can swap in various combiner types without modifying their pipeline. It also makes implementing more complex uncertainty propogation schemes a la #569 much easierThe text was updated successfully, but these errors were encountered: