Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragments don't get shown in RevealJS #353

Open
nicojs opened this issue Nov 20, 2024 · 4 comments
Open

Fragments don't get shown in RevealJS #353

nicojs opened this issue Nov 20, 2024 · 4 comments

Comments

@nicojs
Copy link
Contributor

nicojs commented Nov 20, 2024

When running decktape in revealjs, fragments don't get shown.

For example, this:

### Fragments

Hide and show elements in a sequence with fragments.

```md
<div class="fragment">Fragment 1.</div>
<div class="fragment">Fragment 2.</div>
```

<div class="fragment">Fragment 1.</div>
<div class="fragment">Fragment 2.</div>

Gets printed as this:

image

I've traced the problem. Configuring fragments in the reveals plugin is possible, but it isn't possible to configure it.

See https://github.com/astefanutti/decktape/blob/master/plugins/reveal.js#L22

I'm pretty sure this used to work. I think cad6569 might have broken it.

@nicojs
Copy link
Contributor Author

nicojs commented Nov 20, 2024

Ok, I found the issue. The options from reveal don't get applied when the command is automatic. This effectively makes automatic mode unusable for reveal presentations.

As mentioned, this used to work, so I think it is a regression.

Current workaround is to use "reveal" mode explicitly:

- decktape http://localhost:15000 out.pdf
+ decktape reveal http://localhost:15000 out.pdf

@astefanutti
Copy link
Owner

I wonder if that could be caused by 83771f9 instead.

My understanding is that fragments used to be disabled by default. It used to be possible to enable them via the URL, but indeed now it's a CLI option, it can only be enabled with decktape reveal --fragments.

@nicojs
Copy link
Contributor Author

nicojs commented Nov 20, 2024

I think the fix should be to also apply options for discovered UI libraries using automatic mode.

@astefanutti
Copy link
Owner

Right, the automatic sub-command should ideally pass-through all the options to the selected plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants