Add RISE-lab plugin for jupyterlab_rise #326
Conversation
plugins/rise-lab.js
Outdated
| } | ||
|
|
||
| isActive() { | ||
| return true; |
There was a problem hiding this comment.
This can break other plugins activation. Would there be a more robust way to detect it's called in a jupyterlab_rise context?
Alternatively, we could exclude the plugin here:
Line 350 in 6735cec
but I'd rather go with the former approach.
There was a problem hiding this comment.
Ah, good point. So this would break automatic plugin selection. I'll check if there is a way to tell whether we are in the correct context without waiting for the presentation to be loaded, but it will take a while until I'll get around to that. If I don't find anything, would it be permissible to do a waitForSelector and only return after a not-too-long timeout?
|
Ok, I've added a very basic |
This adds a plugin for jupyterlab_rise. The current RISE plugin is not compatible with it. It is not very smart, instead of trying to access the underlying reveal.js, it steps through the slides and observes whether the slide anchor in the window URL was updated, otherwise it assumes we reached the end.
It requires jupyter to be invoked with
jupyter lab(notjupyter notebook), and then to be passed an URL of the form:http://server:port/rise/your_path/your_notebook.ipynb?token=your_tokenWorks for me, maybe it will be useful for others!
closes #325