Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cricinfo: Some enhancements and ideas #15

Open
ajayrajsrivastava opened this issue Jun 16, 2024 · 1 comment
Open

Cricinfo: Some enhancements and ideas #15

ajayrajsrivastava opened this issue Jun 16, 2024 · 1 comment

Comments

@ajayrajsrivastava
Copy link

ajayrajsrivastava commented Jun 16, 2024

Hi Ashish,

  1. For each ball we can add BallEvent enum.. which tells any event that has happened for that particular Ball. Example - DOT, SIX, FOUR, CATCH, RUNOUT etc
  2. Instead of creating a List we can have an array of fixed Ball size[6]
  3. Instead of an Integer score, we can keep an object Score (which has both runs and wicket info - like 110/8 instead of just 110)
  4. We can add a commentary String object for each Ball

Thanks,
Ajay

@ashishps1
Copy link
Owner

These are great points, thanks for the suggestion.

Feel free to create a pull request or I will try to add these changes in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants