-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew setup instructions are incorrect #425
Comments
I tried installing asdf for the first time tonight, and it did not work (as this issue suggests). I was digging into it on my system and left some notes for someone who is more fluent in brewing (and/or this project). Hopefully this is helpful for someone. |
Same issue here, after running
|
The issue @ttilberg linked to has helped me solve the same problem. TLDR: put |
Note: If a homebrew user already has bash completion configured for homebrew (see: configuring-completions-in-bash), or has properly installed the |
Is this still an ongoing issue? |
@danhper The way the docs are structured focuses on installation via Git. If I were to update the docs for this purpose, I'd be inclined to also add tabs to the Install asdf-vm section with Homebrew specific installation instructions, so that the instructions in Add to your Shell have a bit more context available. Installing via Git would naturally not require Homebrew specific instructions, whether or not Homebrew is used. Thoughts? |
@dboune I agree with this. I suppose installing via Homebrew is a common choice for macOS user so having a dedicated section is, I think, a good idea. |
@danhper - I had the same thought, and indeed, no nested tabs :( The only thing I can think of to keep the structure and not start branching pages is to either refer to the previous section, or make the assumption that the user will pick the appropriate tab as they go along. There is a realistic chance that someone could come along wanting macOS + Homebrew + ZSH or FISH for example, and be willing to add it to the docs, so keeping the tabs for install instructions makes sense. |
In Docsify, the first tab is the default selection, so in the |
I’ll be happy to go ahead and submit a PR just with simple tabs for the Install and Shell sections that includes the Homebrew instructions making the general assumption that folks will figure out which tabs are applicable to them. If that’s worth the effort, let me know and I’ll get it done. |
@dboune I think most people will be able to figure it out. The ideal solution I ultimately want is to get select boxes for OS, Shell and Install Method, but that will require a lot more work with Docsify or an alternate tool. |
I'm in favour of fast iterations over perfection the first time. Feel free to ping me in subsequent PRs if there are immediate issues with this 😄 |
https://asdf-vm.com/#/core-manage-asdf-vm To make homebrew's completions available in bash, you must source the definitions as part of your shell startup. They have to be in your PATH. For me, on a Mac, this simply means running each of these commands The second command is unnecessary if you have configured completions for Homebrew in ~/.bash_profile Homebrew bash configuration completion code: asdf install instructions for each system here: |
As I said in #425 (comment)
we have updated the docs (https://asdf-vm.com/#/core-manage-asdf-vm) with select boxes to choose your setup and get just the information for your setup. Hope this helps |
The setup instructions are incorrect - the Homebrew formula installs things a bit differently.
The paths (in case of Bash) are:
The text was updated successfully, but these errors were encountered: