Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with omniauth-constantcontact gem #3

Open
calebjclark opened this issue Sep 1, 2012 · 12 comments
Open

Merge with omniauth-constantcontact gem #3

calebjclark opened this issue Sep 1, 2012 · 12 comments

Comments

@calebjclark
Copy link

@asanghi, I'm the developer of the omniauth-constantcontact gem. I see little reason to maintain both OAuth1 and OAuth2 gems for ConstantContact, especially now that CC has depreciated support for OAuth1. How about replacing my 'omniauth-constantcontact' gem with your version?

@asanghi
Copy link
Owner

asanghi commented Sep 1, 2012

Sounds okay to me! No point keeping the confusion of 2 around.

@calebjclark
Copy link
Author

What's the best way to update the omniauth-contactcontact gem to use your OAuth2 version? Should I add you to the list of gem owners and let you push a version 2 of the gem?

@michaelherold
Copy link

Just wondered if you guys were still planning to merge these two gems or keep them separate. I'm going to incorporate this into a project and am looking for a heads-up on whether to expect a deprecation due to the merging of the two gems.

@asanghi
Copy link
Owner

asanghi commented Jan 5, 2015

Well there has been no conversation around this for over two years now. I'm not using this gem myself. Happy to let someone else take ownership and merge.

@calebjclark
Copy link
Author

I don't use the gem either, but I'm happy to hand off whatever is needed for the merge.

@pcai
Copy link
Collaborator

pcai commented Jun 16, 2015

Hi @asanghi - I'm happy to take ownership of this gem if you are still looking for someone to help with maintenance.

@asanghi
Copy link
Owner

asanghi commented Jun 16, 2015

Sounds great! Added @pcai to the repo. Do as you please!

@asanghi asanghi closed this as completed Jun 16, 2015
@asanghi asanghi reopened this Jun 16, 2015
@pcai
Copy link
Collaborator

pcai commented Jun 16, 2015

@asanghi Thanks! Would you be able to add me as an owner on the rubygem as well, so I can publish new releases?

@asanghi
Copy link
Owner

asanghi commented Jun 16, 2015

@pcai i think i need your email address for that.

@asanghi
Copy link
Owner

asanghi commented Jun 16, 2015

..and done!

@pcai
Copy link
Collaborator

pcai commented Jun 19, 2015

@calebclark I am a new collaborator on this gem and I agree it would be good to merge with yours, can you add me to it on github and rubygems? My gmail username is linker.error. I would be happy to take care of it for you. Or we can discuss details here if you like.

@calebjclark
Copy link
Author

@pcai I have added you to both github and rubygems. Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants