Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a: font: german umlauts won't work. #141

Open
dertuxmalwieder opened this issue May 17, 2018 · 4 comments
Open

a: font: german umlauts won't work. #141

dertuxmalwieder opened this issue May 17, 2018 · 4 comments
Assignees
Labels

Comments

@dertuxmalwieder
Copy link

I press "test äöüß".

a gives me:

Screenshot

@as as self-assigned this May 20, 2018
@as as added the bug label May 20, 2018
@as
Copy link
Owner

as commented May 21, 2018

In earlier versions, this was resolved by running the program with a -u to enable utf8 support.

In the current version, this won't work. The program will run, but will crash when a utf8 multi-byte glyph is rendered due to a known but untracked bug in the as/fonts package.

Ultimately, there should be a way to render valid utf8 runes and revert to byte representation when an error replacement character is normally encountered. I haven't looked into that yet, but there would need to be an efficient way of doing that.

In the meantime, this is a good reminder for me to write up that fonts bug and fix it when time permits so that the -u flag actually works.

@dertuxmalwieder
Copy link
Author

Wouldn't it make more sense to have a support UTF-8 by default?

@as
Copy link
Owner

as commented May 21, 2018

Yes, eventually. The problem of utf8 not being idempotent prevented this from being the default before (invalid utf8 is converted one way into a replacement character which is unacceptable for binary files).

The flag -u is off by default because it's not well tested yet, but it shouldn't crash when enabled anymore.

@as as changed the title German umlauts won't work. a: font: german umlauts won't work. May 29, 2018
@dertuxmalwieder
Copy link
Author

FYI, -u is still not quite working.

New Windows 10 machine, fresh Go installation, typing "Zäune und Bäume" ("fences and trees", does not need to make sense, does it?) inside a -u:

a_2018-06-18_23-56-50

You might see the superfluous spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants