Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp of code to use go string manipulation instead of system command line tools #2

Open
abstractninjatur opened this issue Jan 15, 2024 · 3 comments

Comments

@abstractninjatur
Copy link

The code contains the logic to invoke system command line tools to find and replace the set-output line. Instead of this use go string manipluation.

@sharunkumar
Copy link

Just adding my 2 cents here: doing it in go will add more complexity like you would have to handle different new line characters, encodings, etc. Using sed I think, already does all of that for you

@arunsathiya
Copy link
Owner

There are definitely pros and cons to each approach! I am going to ponder on this for a few days and make changes, and most specifically, I want to refactor the current code to be concise.

@abstractninjatur
Copy link
Author

Just adding my 2 cents here: doing it in go will add more complexity like you would have to handle different new line characters, encodings, etc. Using sed I think, already does all of that for you

Yeah, True, IMO we can use shell script instead of go to use the system commands like sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants