-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 - Add Carmomaq Roasters #1233
Conversation
add Carmomaq Machine - Caloratto.
Carmomaq Machines - Speciatto, Stratto and Masteratto
✅ Build artisan 83b2d31 (860) completed (commit 83b2d3157c by @gustavopradof) |
Thanks for your PR! What about keeping the old setups, just renamed as Regarding those 4 new setups (which are all quite similar), let me ask some clarifying questions on
There are 6 MODBUS inputs active (slave != 0) in MODBUS tab , but no extra device is defined to read those additional inputs 3-6. I assume that those registers 45, 46 and 47 hold the data for Gas, Drum and Air. This data is most likely in 0-100%, thus the "Mode" should not be "C" but the empty entry, right? What does register 49 holds, the register which is written to by slider 3 (Vent. Press)? Defining extra devices to read this data allows to synchronise changes set by controls on the machine to the Artisan software via is event quantifiers.
Currently the 4 event names are (english defaults in brackets)
It is preferable to keep this names in the setup by their default english terms such that the translations build into Artisan can translate them to all 20+ supported languages. Not everybody speaks Portuguese;) The default Portuguese translations correspond with the terms used by this setup, but for
What exactly is "Vent. Press" referring too?
What is the effect of sending value 2 to register 50 on OFF and value 1 to register 50 on START?
There are 12 Event buttons defined. Could you confirm the following action on the machine side? What are the last two buttons doing?
Organizing those buttons a bit differently we could have the localized into all languages supported by Artisan. |
Are you available for testing? |
- faster WebLCDs startup - delayed start of WebLCDs on app start - use spawn instead fork multiprocessing also on macOS (now supported by py2app) - fixes missing qtbase translations - updated translations - adds additional translatable button labels (\i: STIRRER, \f: FILL, \r: RELEASE) - adds further Carmomaq machine setups (PR #1233)
These settings don't work with any equipment so I deleted it. There are 6 MODBUS inputs active (slave != 0) in MODBUS tab , but no extra device is defined to read those additional inputs 3-6. I assume that those registers 45, 46 and 47 hold the data for Gas, Drum and Air. This data is most likely in 0-100%, thus the "Mode" should not be "C" but the empty entry, right? That's right, the "C" is wrong I must have configured it wrong. What does register 49 holds, the register which is written to by slider 3 (Vent. Press)? Masteratto contains 2 fans, one for the cyclone and the other to remove pressure from the roaster, register 49 is the pressure fan control from 0 to 120%. What exactly is "Vent. Press" referring too? Is "Potencia" a better translation for "Burner" as "Chama" which is currently used by Artisan? It depends, we maintain "Potência" because we have electric and gas roasters, but for "Burner" the correct one is "Chama" What is the effect of sending value 2 to register 50 on OFF and value 1 to register 50 on START? Register 50 is for starting the roaster timer, value 1 is for start and 2 for stop. Are those sliders intentionally ranging from 0-120% and not just 0-100%? Yes, fan and cylinder can be adjusted from 0-120%
|
I made a continuous build adding 4 new setups for the Carmomaq https://github.com/artisan-roaster-scope/artisan/releases/tag/continuous based on your work.
Could you please test if those setups work as intended? |
Everything worked, both buttons and sliders. |
Thanks for checking. I will close this PR as the changes have already been added to trunk and will be part of the next release. |
Hello, I'm responsible for the automation part of Carmomaq. The settings present in artisan don't work as expected since the release in 2020 I'm posting the updated files