Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is that true the source and target embedding space should have the same dimensionality? #2

Open
yuchenlin opened this issue Jul 31, 2017 · 4 comments

Comments

@yuchenlin
Copy link

yuchenlin commented Jul 31, 2017

Hi Mikel,

I found that you didn't mention the case that the source embeddings and target embeddings can have different dimensionality (for example, english 300d, and Chinese 100d).
Did I miss something in the paper or the code? Or you only focus on the situation that the two embedding spaces must have the same dimensionality?

Thanks and regards,
Bill

@artetxem
Copy link
Owner

artetxem commented Aug 4, 2017

You are right, we currently do not support both spaces having different dimensionality. It should not be difficult to implement it, but I do not think that it would be particularly useful either. I will leave the issue open for now.

@shizhediao
Copy link

what if the source embedding is 200000300 while the target embedding is 199999300, could it be trained correctly by this code?
thanks!

@shizhediao
Copy link

@artetxem

@artetxem
Copy link
Owner

@shizhediao that should work ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants