Warning is shown when keyboard is shown

[gkorland]

When the keyboard is shown a warning that the site is in Landscape is wrongly shown.

[arscan]

Ah, good point. I'm just checking to see if the window width (or maybe the document width?) is bigger than the height, which is pretty hacky and behaves incorrectly in this case. I wonder if there is a more robust manner of figuring out orientation now that devices have matured a bit. Thanks for reporting this. It might take me a few weeks before I'll have time to address this though, so if you are interested in putting together a fix I'd be thrilled to accept a PR.

[mkarya001]

Fixed that issue and its working perfect for me i have created a new variable

var windowint = window.innerWidth;

and modified checkOrientationChange();

`

function checkOrientationChange(){
    if(!isMobile && options.onlyMobile){
        if(!init){
            init = true;
            setVisibility(false);
            setBodyClass("hiding");
            options.onHide(); // run this exactly once if not mobile
        }
        return;
    }

    if(currentOrientation !== isPortrait()){
        if(windowint == window.innerWidth){
            currentOrientation = true;
        }else{
            currentOrientation = false;
        }
        
        orientationChanged();
    }
}

`

[mkarya001]

or quite simple approach is to modify isPortrait()

var windowint = window.innerWidth;

function isPortrait(){ return ( window.innerWidth < window.innerHeight || windowint == window.innerWidth); }

[Paran0idAndr0id]

@mkarya001

Would you mind posting a full version of your script? I'm not getting your changes to work.

[mkarya001]

@Paran0idAndr0id download here

[arscan]

Could you fork this repo and create a pull request @mkarya001? That way I can merge in your fixes so that everyone will get the updates going forward. Thanks for your help!

[mkarya001]

@arscan sure