-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic pdf output... #96
Comments
It seems it is now possible to get a link via API to the artifact: https://developer.github.com/v3/actions/artifacts/ https://nightly.link/armbian/documentation/workflows/recreate_on_push.yaml/master/artifact.zip should lead always to the latest artifact. |
This is all very neat and everything, but are we actually using the generated PDFs for anything? I have not played with Docs in some time, but I seem to recall that commenting out And if we are not using them for anything (yet) maybe we should comment this out by default until we are? |
Sure, go ahead. I don't think it is used atm. |
OK cool, thanks. I am sending a few more touch ups on Board Maintainers, then will start on other things. |
OK, commented out in #176. Do we still want to keep this open? I dunno what you had/have in mind here. |
Now action is failing - has to be disabled and badge in readme file. |
Yeah, I had just noticed that, too, and commented in IRC. Looking into it already. |
I am starting to think that I should just undo all this and bring back PDF generation. Maybe some people use it. I did not realize we were actually publishing the produced PDF. |
Just leave as is. We don't use PDF and if needed in the future, we will give this back. |
I dunno, I was all gung-ho to remove it, now thinking why not leave it? Maybe some people use it? But I have no idea, so I started a thread on the forums. I guess it doesn't hurt to leave it? |
There is no damage if we have it since its an automated job. |
OK I will work on putting everything back how it was. Probably after dinner. |
actions are enabled back. at least system for |
You just want to revert back to 9ce3e73? That would revert my breaking change, and put back the badge. Basically back to where we were. I:
Barring above, I guess I can just undo those two small changes the regular way, moving forward from here. |
Done in CLI. I also don't know how to do it on Github. |
... as already been played around with Github actions and proofen to work 😛
@lanefu
The text was updated successfully, but these errors were encountered: