Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic pdf output... #96

Closed
EvilOlaf opened this issue Oct 2, 2020 · 16 comments
Closed

Automatic pdf output... #96

EvilOlaf opened this issue Oct 2, 2020 · 16 comments
Assignees

Comments

@EvilOlaf
Copy link
Member

EvilOlaf commented Oct 2, 2020

... as already been played around with Github actions and proofen to work 😛
@lanefu

@lanefu lanefu self-assigned this Oct 2, 2020
@EvilOlaf
Copy link
Member Author

EvilOlaf commented Oct 4, 2020

Now we have to decide where and how to push the pdf.
512766d
bc699ad

@EvilOlaf
Copy link
Member Author

It seems it is now possible to get a link via API to the artifact: https://developer.github.com/v3/actions/artifacts/
Also interesting: https://github.com/oprypin/nightly.link

https://nightly.link/armbian/documentation/workflows/recreate_on_push.yaml/master/artifact.zip should lead always to the latest artifact.

@TRSx80
Copy link
Member

TRSx80 commented Jan 31, 2022

This is all very neat and everything, but are we actually using the generated PDFs for anything?

I have not played with Docs in some time, but I seem to recall that commenting out - with-pdf: line in mkdocs.yml cut my local rendering time down from minutes to seconds. Which helps a lot while editing docs locally, before pushing changes back up.

And if we are not using them for anything (yet) maybe we should comment this out by default until we are?

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Feb 1, 2022

Sure, go ahead. I don't think it is used atm.

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

OK cool, thanks. I am sending a few more touch ups on Board Maintainers, then will start on other things.

@TRSx80 TRSx80 closed this as completed Feb 1, 2022
@TRSx80 TRSx80 reopened this Feb 1, 2022
@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

OK, commented out in #176.

Do we still want to keep this open? I dunno what you had/have in mind here.

@igorpecovnik
Copy link
Member

Now action is failing - has to be disabled and badge in readme file.
https://github.com/armbian/documentation/actions/runs/1778956948

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

Yeah, I had just noticed that, too, and commented in IRC. Looking into it already.

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

I am starting to think that I should just undo all this and bring back PDF generation. Maybe some people use it. I did not realize we were actually publishing the produced PDF.

@igorpecovnik
Copy link
Member

Just leave as is. We don't use PDF and if needed in the future, we will give this back.

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

I dunno, I was all gung-ho to remove it, now thinking why not leave it? Maybe some people use it? But I have no idea, so I started a thread on the forums. I guess it doesn't hurt to leave it?

@igorpecovnik
Copy link
Member

I guess it doesn't hurt to leave it?

There is no damage if we have it since its an automated job.

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

OK I will work on putting everything back how it was. Probably after dinner.

@igorpecovnik
Copy link
Member

igorpecovnik commented Feb 1, 2022

actions are enabled back. at least system for

@TRSx80
Copy link
Member

TRSx80 commented Feb 1, 2022

You just want to revert back to 9ce3e73? That would revert my breaking change, and put back the badge. Basically back to where we were.

I:

  1. don't know how to do that in GitHub though (only on command line)
  2. whether I even have permission to do so
  3. how this affects other people's work

Barring above, I guess I can just undo those two small changes the regular way, moving forward from here.

@igorpecovnik
Copy link
Member

Done in CLI. I also don't know how to do it on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants