Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darker shades / lightness consistency #438

Open
toastal opened this issue Nov 21, 2023 · 1 comment
Open

Darker shades / lightness consistency #438

toastal opened this issue Nov 21, 2023 · 1 comment

Comments

@toastal
Copy link

toastal commented Nov 21, 2023

Looking at the Colors section, these there is a scale from 0 to 12. The 0 (& often the 1 as well) is perceptually pretty “close” to white, but, with the exception of ‘gray’, ‘stone’ & ‘sand’, the 12 value is nowhere near as close to black (to test, :root { --surface: #000 } to simulate an “OLED Black” theme). Extrapolating the current scale, the ‘yellow’ I should be able to get to yellow-15 at that scale before one would hit black.

I would expect something like oklab to keep the lightness consistent across the 0­–12 across any color scheme. I would either expect 12 to be nearer to black or the scale extended to 15 for these darker shades missing in almost every color which is less likely to break existing code.

Currently I’m extending blue-15, lime-15, violet-15, yellow-15, orange-15, & red-15 for --surface-* values in a theme just to get these necessary values for my OLED-compatible theme, & while I have the ability to make my own color scales, surely I’m not the only one experiencing this issue for the default setup.

@argyleink
Copy link
Owner

excellent observations and nice customizations 👍🏻

these colors have been tested across a lot of bummer screens too, and account for that variety.

the next version of colors will be based on oklch and will feature much of what you're doing as well. so expect these upgrades in OPv2 (coming soon). it'll also be a scale of 1-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants